Skip to content

Fix incompatibilities with new Analyzer. #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2018
Merged

Fix incompatibilities with new Analyzer. #1768

merged 2 commits into from
Oct 1, 2018

Conversation

scheglov
Copy link
Contributor

@scheglov scheglov commented Oct 1, 2018

  1. CompilationUnitElement.name is now always null. If you need to get a short name of a file - extract it from the full name.

  2. ResourceProvider requires all names to be absolute and normalized. And /my/path/ is not normalized, it should be /my/path.

@bwilkerson

@scheglov scheglov requested a review from jcollins-g October 1, 2018 01:58
@googlebot googlebot added the cla: yes Google CLA check succeeded. label Oct 1, 2018
@scheglov scheglov merged commit b23e37d into master Oct 1, 2018
@scheglov scheglov deleted the fixes-for-new-analyzer branch October 1, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scheglov @jcollins-g @googlebot